Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 587943002: Don't start PseudoTCP until underlying transport is connect. (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't start PseudoTCP until underlying transport is connect. Previously LibjingleTransportFactory was creating and returning transport before the transport is connected. This means that that the PseudoTCP was trying to start handshake on a broken transport. That was delaying PseudoTCP/SSL when the transport takes some time to setup (e.g. over STUN/Relay). Now LibjingleTransportFactory returns the transport only after it becomes writable. Empirical testing shows that this change makes connection initiation much faster in cases when NAT traversal is required (4 vs 10 seconds). Committed: https://crrev.com/bf00a43689c645029d918a42493ab66d8b3aa5b0 Cr-Commit-Position: refs/heads/master@{#295862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M remoting/protocol/libjingle_transport_factory.cc View 5 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-20 00:17:24 UTC) #2
Wez
lgtm
6 years, 3 months ago (2014-09-20 01:47:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587943002/1
6 years, 3 months ago (2014-09-20 01:48:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a430b1083ad1023c2768fd9d95df7c858ecb2b6f
6 years, 3 months ago (2014-09-20 13:15:39 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 13:16:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf00a43689c645029d918a42493ab66d8b3aa5b0
Cr-Commit-Position: refs/heads/master@{#295862}

Powered by Google App Engine
This is Rietveld 408576698