Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 587933003: [NaCl SDK] nacl_io: Fix html5fs stat on directories (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
bradnelson, bradn, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Fix html5fs stat on directories This used to return RWX, but regressed as of 314a240ec3fd6a40f9e2e543fa692eb44d667ab2. BUG=none R=sbc@chromium.org R=bradnelson@chromium.org Committed: https://crrev.com/865a65ad84ac9a6b1a89aaf3bfb0fe77fc6be3d9 Cr-Commit-Position: refs/heads/master@{#295844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc View 1 chunk +5 lines, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/html5_fs_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
binji
6 years, 3 months ago (2014-09-20 00:02:13 UTC) #1
bradn
lgtm
6 years, 3 months ago (2014-09-20 00:02:47 UTC) #3
Sam Clegg
lgtm
6 years, 3 months ago (2014-09-20 00:08:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587933003/1
6 years, 3 months ago (2014-09-20 00:32:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587933003/1
6 years, 3 months ago (2014-09-20 00:32:41 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-20 02:13:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as a1e61f929fed323ab558ab4ccc835de3bd66d523
6 years, 3 months ago (2014-09-20 02:13:53 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 02:14:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/865a65ad84ac9a6b1a89aaf3bfb0fe77fc6be3d9
Cr-Commit-Position: refs/heads/master@{#295844}

Powered by Google App Engine
This is Rietveld 408576698