Issue 587933002: Remove old navigation APIs from RenderViewHost.

Issue 587933002: Remove old navigation APIs from RenderViewHost. (Closed)

Created:
6 years, 3 months ago by Charlie Reis

Modified:
6 years, 3 months ago

Reviewers:
nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove old navigation APIs from RenderViewHost. BUG=304341 TEST=Interstitial pages still work. Committed: https://crrev.com/257bbb21a16fe457e32b3cf4feb17bbd5f362b51 Cr-Commit-Position: refs/heads/master@{#295989}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -26 lines)			Patch
M	content/browser/frame_host/interstitial_page_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 7 (2 generated)

nasko

Removing dead code - totally LGTM! Thanks for cleaning those up!

6 years, 3 months ago (2014-09-22 13:59:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587933002/1

6 years, 3 months ago (2014-09-22 16:11:30 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 0e81ba74c4507167310f4c729166bc414ac0b162

6 years, 3 months ago (2014-09-22 16:38:46 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 16:39:36 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/257bbb21a16fe457e32b3cf4feb17bbd5f362b51
Cr-Commit-Position: refs/heads/master@{#295989}