Issue 58793002: Fix ::GetBounds() and ::SetBounds() in NativeAppWindowGtk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58793002: Fix ::GetBounds() and ::SetBounds() in NativeAppWindowGtk. (Closed)

Created:
7 years, 1 month ago by mlamouri (slow - plz ping)

Modified:
7 years, 1 month ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix ::GetBounds() and ::SetBounds() in NativeAppWindowGtk. Hopefully, this might fix a few bugs that we see in Linux/GTK. BUG=309969, 311759 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233223

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	chrome/browser/ui/gtk/apps/native_app_window_gtk.cc	View		3 chunks	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mlamouri (slow - plz ping)

By the way Ben, this should fix the moving window bug your synthesizer app had ...

7 years, 1 month ago (2013-11-05 02:07:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/58793002/1

7 years, 1 month ago (2013-11-05 07:08:40 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184944

7 years, 1 month ago (2013-11-05 09:12:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/58793002/1

7 years, 1 month ago (2013-11-06 00:12:59 UTC) #5

Message was sent while issue was closed.

Change committed as 233223

Expand Messages | Collapse Messages