Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 587893003: Test generation of global initializers in Subzero bitcode reader. (Closed)

Created:
6 years, 3 months ago by Karl
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Test generation of global initializers in Subzero bitcode reader. Adds workaround that uses IceConverter's convertGlobals to generate global initializers. This should complete the initial implementation of Subzero's bitcode reader. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3892 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6ff33d2fdba1ae8dde5e6409d4a21e1e875dcf56

Patch Set 1 #

Patch Set 2 : Fix nits. #

Total comments: 2

Patch Set 3 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -61 lines) Patch
M src/IceConverter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/IceConverter.cpp View 1 chunk +1 line, -44 lines 0 comments Download
M src/IceTranslator.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/IceTranslator.cpp View 2 chunks +48 lines, -0 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 2 4 chunks +29 lines, -10 lines 0 comments Download
A + tests_lit/reader_tests/globalinit.pnacl.ll View 2 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
6 years, 3 months ago (2014-09-19 22:16:20 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/587893003/diff/20001/src/PNaClTranslator.cpp File src/PNaClTranslator.cpp (right): https://codereview.chromium.org/587893003/diff/20001/src/PNaClTranslator.cpp#newcode2227 src/PNaClTranslator.cpp:2227: // True if we have already install names ...
6 years, 3 months ago (2014-09-22 17:01:43 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as 6ff33d2 (presubmit successful).
6 years, 3 months ago (2014-09-22 17:28:50 UTC) #5
Karl
6 years, 3 months ago (2014-09-22 17:29:22 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/587893003/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/587893003/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:2227: // True if we have already install names for
unnamed global addresses,
On 2014/09/22 17:01:43, stichnot wrote:
> installed

Done.

Powered by Google App Engine
This is Rietveld 408576698