Issue 587873002: ES6: Disallow binary and octal representation in Number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587873002: ES6: Disallow binary and octal representation in Number (Closed)

Created:
6 years, 3 months ago by arv (Not doing code reviews)

Modified:
6 years, 2 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

ES6: Disallow binary and octal representation in Number ToNumber should return NaN for '0b01' and '0o76'. BUG=v8:3585 LOG=Y

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -40 lines)			Patch
	M	src/runtime.cc	View		1 chunk	+3 lines, -9 lines	0 comments	Download
	M	test/mjsunit/harmony/numeric-literals.js	View		1 chunk	+42 lines, -31 lines	0 comments	Download

Total messages: 3 (1 generated)

arv (Not doing code reviews)

I hope to get this resolved at TC39 next week.

6 years, 3 months ago (2014-09-19 21:05:06 UTC) #2

arv (Not doing code reviews)

6 years, 2 months ago (2014-09-25 15:22:27 UTC) #3

Going to close this after TC39's conclusion to make ToNumber support all number
literals.