Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 587853002: Chromecast: adds Gpu/Network/Profiler metrics providers. (Closed)

Created:
6 years, 3 months ago by gunsch
Modified:
6 years, 3 months ago
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds Gpu/Network/Profiler metrics providers. R=asvitkine@chromium.org,lcwu@chromium.org BUG=400925 Committed: https://crrev.com/25deaa9ef9f22d2da25872905bb25434e63d49e3 Cr-Commit-Position: refs/heads/master@{#295810}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/metrics/cast_metrics_service_client.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chromecast/metrics/cast_metrics_service_client.cc View 4 chunks +17 lines, -3 lines 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
gunsch
6 years, 3 months ago (2014-09-19 20:40:25 UTC) #1
Alexei Svitkine (slow)
LGTM
6 years, 3 months ago (2014-09-19 20:45:32 UTC) #2
lcwu1
lgtm
6 years, 3 months ago (2014-09-19 20:50:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587853002/1
6 years, 3 months ago (2014-09-19 20:53:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11527)
6 years, 3 months ago (2014-09-19 22:11:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11527)
6 years, 3 months ago (2014-09-19 22:12:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587853002/1
6 years, 3 months ago (2014-09-19 23:08:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 345c476a91574e6825273176ed0706462ea7c61a
6 years, 3 months ago (2014-09-19 23:34:59 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 23:35:48 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/25deaa9ef9f22d2da25872905bb25434e63d49e3
Cr-Commit-Position: refs/heads/master@{#295810}

Powered by Google App Engine
This is Rietveld 408576698