Test wallpaper picker app could launch in dev and stable channel

Test wallpaper picker app could launch in dev and stable channel

BUG=416130, 410550
Committed: https://crrev.com/bc97b25aaaf9d62960963c8218a0b497c69db0d1
Cr-Commit-Position: refs/heads/master@{#296277}

[bshe, 2014-09-19 20:45:10]

bshe@chromium.org changed reviewers:
+ kevers@chromium.org, miket@chromium.org

[bshe, 2014-09-19 20:45:10]

Hi guys.

Do you mind to take a look at this test? I am trying to test that wallpaper
picker can successfully create an app window in the background page and the
created window could load its content successfully.

Thanks!

Biao

[miket_OOO, 2014-09-22 02:57:05]

I love tests! LGTM

[kevers, 2014-09-23 13:23:40]

LGTM with optional nit.

https://codereview.chromium.org/587843002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc
(right):

https://codereview.chromium.org/587843002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc:61:
extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_STABLE);
Optional: Create a private method with the common code between DevLaunchApp and
StableLaunchApp to reduce code duplication.

[bshe, 2014-09-23 20:58:21]

Thanks for review

https://codereview.chromium.org/587843002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc
(right):

https://codereview.chromium.org/587843002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc:61:
extensions::ScopedCurrentChannel channel(chrome::VersionInfo::CHANNEL_STABLE);
On 2014/09/23 13:23:40, kevers wrote:
> Optional: Create a private method with the common code between DevLaunchApp
and
> StableLaunchApp to reduce code duplication.
> 

Done.

[bshe, 2014-09-23 20:58:30]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:00:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/587843002/60001

[commit-bot: I haz the power, 2014-09-23 22:05:27]

Committed patchset #4 (id:60001) as 1bc9228942e0641ff7a92d206bf847818923ceed

[commit-bot: I haz the power, 2014-09-23 22:06:14]

Patchset 4 (id:??) landed as
https://crrev.com/bc97b25aaaf9d62960963c8218a0b497c69db0d1
Cr-Commit-Position: refs/heads/master@{#296277}