Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: icu.gyp

Issue 587833004: Turn on UCONFIG_NO_NON_HTML5_CONVERTER to save 100kB (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « android/icudtl.dat ('k') | patches/converters.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'icu.gypi', 7 'icu.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'use_system_icu%': 0, 10 'use_system_icu%': 0,
11 'icu_use_data_file_flag%': 0, 11 'icu_use_data_file_flag%': 0,
12 'want_separate_host_toolset%': 1, 12 'want_separate_host_toolset%': 1,
13 }, 13 },
14 'target_defaults': { 14 'target_defaults': {
15 'direct_dependent_settings': { 15 'direct_dependent_settings': {
16 'defines': [ 16 'defines': [
17 # Tell ICU to not insert |using namespace icu;| into its headers, 17 # Tell ICU to not insert |using namespace icu;| into its headers,
18 # so that chrome's source explicitly has to use |icu::|. 18 # so that chrome's source explicitly has to use |icu::|.
19 'U_USING_ICU_NAMESPACE=0', 19 'U_USING_ICU_NAMESPACE=0',
20 # We don't use ICU plugins and dyload is only necessary for them. 20 # We don't use ICU plugins and dyload is only necessary for them.
21 # NaCl-related builds also fail looking for dlfcn.h when it's enabled. 21 # NaCl-related builds also fail looking for dlfcn.h when it's enabled.
22 'U_ENABLE_DYLOAD=0', 22 'U_ENABLE_DYLOAD=0',
23 # Only build encoding coverters and detectors necessary for HTML5.
24 'UCONFIG_NO_NON_HTML5_CONVERSION=1',
Mark Mentovai 2014/09/23 21:59:03 Is this needed? It’s only needed if UCONFIG_NO_NO
jungshik at Google 2014/09/24 20:56:48 That's what I guessed, but was not sure about dire
jungshik at Google 2014/09/24 21:06:11 To be precise, public headers (in source/{common,i
23 ], 25 ],
24 }, 26 },
25 'defines': [ 27 'defines': [
26 'U_USING_ICU_NAMESPACE=0', 28 'U_USING_ICU_NAMESPACE=0',
27 'HAVE_DLOPEN=0', 29 'HAVE_DLOPEN=0',
30 'UCONFIG_NO_NON_HTML5_CONVERSION=1',
28 ], 31 ],
29 'conditions': [ 32 'conditions': [
30 ['component=="static_library"', { 33 ['component=="static_library"', {
31 'defines': [ 34 'defines': [
32 'U_STATIC_IMPLEMENTATION', 35 'U_STATIC_IMPLEMENTATION',
33 ], 36 ],
34 }], 37 }],
35 ['(OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \ 38 ['(OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
36 or OS=="netbsd" or OS=="mac" or OS=="android" or OS=="qnx") and \ 39 or OS=="netbsd" or OS=="mac" or OS=="android" or OS=="qnx") and \
37 (target_arch=="arm" or target_arch=="ia32" or \ 40 (target_arch=="arm" or target_arch=="ia32" or \
(...skipping 583 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 }, 624 },
622 'includes': [ 625 'includes': [
623 '../../build/shim_headers.gypi', 626 '../../build/shim_headers.gypi',
624 ], 627 ],
625 'toolsets': ['target'], 628 'toolsets': ['target'],
626 }, 629 },
627 ], # targets 630 ], # targets
628 }], 631 }],
629 ], # conditions 632 ], # conditions
630 } 633 }
OLDNEW
« no previous file with comments | « android/icudtl.dat ('k') | patches/converters.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698