Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 587823003: Cleanup: Remove base/file_util.h. Convert remaining references. (try 2) (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove base/file_util.h. Convert remaining references. (try 2) TBR=brettw@chromium.org Committed: https://crrev.com/0c8a9bb8b69ca63fbf68f12e7a9f672b18899646 Cr-Commit-Position: refs/heads/master@{#296020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M android_webview/browser/renderer_host/print_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/cookie_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/light_bar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_mementos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/profile_reset/jtl_compiler_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Lei Zhang
here we go again...
6 years, 3 months ago (2014-09-19 21:23:21 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-19 21:24:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587823003/1
6 years, 3 months ago (2014-09-19 21:25:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587823003/1
6 years, 3 months ago (2014-09-19 21:25:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11545)
6 years, 3 months ago (2014-09-19 22:27:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11545)
6 years, 3 months ago (2014-09-19 22:28:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587823003/1
6 years, 3 months ago (2014-09-22 19:02:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5674f3a73553fdd5f27b11d4f62f61b74fa47e30
6 years, 3 months ago (2014-09-22 19:06:30 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 19:07:02 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0c8a9bb8b69ca63fbf68f12e7a9f672b18899646
Cr-Commit-Position: refs/heads/master@{#296020}

Powered by Google App Engine
This is Rietveld 408576698