[Search] Add a header image to the promo flow.

chrome/browser/resources/contextual_search/promo.js

 /* Copyright 2014 The Chromium Authors. All rights reserved.
    Use of this source code is governed by a BSD-style license that can be
    found in the LICENSE file.
 */
 
+<include src="../../../../ui/webui/resources/js/util.js">
+<include src="../../../../ui/webui/resources/js/load_time_data.js">
+
+// Used to indicate whether we've treated the header image for possible
+// deletion.
+var treatedHeader = false;
+
 /**
  * On load, registers the handler to add the 'hide' class to the container
  * element in order to hide it.
  */
 window.onload = function() {
+  possiblyRemoveHeader();

[pedro (no code reviews), 2014/09/22 18:25:20]

If we pass the finch config to not render the header, will the height of the
promo be calculated properly from the client? We calculate it when the pages
finishes loading, which might fire before window.onload.

I think it would be better using document.addEventListener("DOMContentLoaded",
function(event) { ... });

[Mathieu, 2014/09/22 21:35:06]

Done. I think so too, thanks.

   $('optin-label').addEventListener('click', function() {
     $('container').classList.add('hide');
   });
 };
 
 /**
+ * Depending on the configuration value, we may need to remove the header image.
+ */
+function possiblyRemoveHeader() {
+  if (treatedHeader) {
+    return;
+  }
+  treatedHeader = true;
+
+  if (config['hideHeader']) {
+    $('container').removeChild($('header-image'));
+  }
+}
+
+/**
  * Returns the height of the content. Method called from Chrome to properly size
  * the view embedding it.
  * @return {number} The height of the content, in pixels.
  */
 function getContentHeight() {
+  possiblyRemoveHeader();

[pedro (no code reviews), 2014/09/22 18:25:20]

I think if you use DOMContentLoaded you will not need to call this from here,
because when the page finishes loading and we call getContentHeight() the header
will be already removed.

[Mathieu, 2014/09/22 21:35:06]

Done.

   return $('container').clientHeight;
 }