Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 587753003: Add caption formatting to css. (Closed)

Created:
6 years, 3 months ago by jpmedley
Modified:
6 years, 2 months ago
Reviewers:
mkearney1, binji
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add caption formatting to css. BUG=none R= TEST=none NOTRY=true (documentation only change) Committed: https://crrev.com/791e8db06375cc5d0a3b3e6e6ebe2027c1772cad Cr-Commit-Position: refs/heads/master@{#297441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/common/extensions/docs/static/css/out/site.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/static/sass/_typography.scss View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jpmedley
I meant to submit this before new images started going out. Captions need to no ...
6 years, 3 months ago (2014-09-23 14:15:18 UTC) #2
jpmedley
Can one of you find a minute to glance at this?
6 years, 2 months ago (2014-09-30 17:14:33 UTC) #3
binji
oops, missed this, sorry. lgtm
6 years, 2 months ago (2014-09-30 17:22:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587753003/1
6 years, 2 months ago (2014-09-30 17:28:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5127439cd922019785dc35443a6c695f7b4b687e
6 years, 2 months ago (2014-09-30 17:29:17 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 17:30:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/791e8db06375cc5d0a3b3e6e6ebe2027c1772cad
Cr-Commit-Position: refs/heads/master@{#297441}

Powered by Google App Engine
This is Rietveld 408576698