Issue 587713002: Added the "DISALLOW_COPY_AND_ASSIGN(Timer);" for Timer class in gin/module/timer.h.

Issue 587713002: Added the "DISALLOW_COPY_AND_ASSIGN(Timer);" for Timer class in gin/module/timer.h. (Closed)

Created:
6 years, 3 months ago by ARUNKK

Modified:
6 years, 3 months ago

Reviewers:
Aaron Boodman, jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Added the "DISALLOW_COPY_AND_ASSIGN(Timer);" for Timer class in gin/module/timer.h. BUG= Committed: https://crrev.com/a3eab57adfb32b95e2cd5abf03b536c4a017aa95 Cr-Commit-Position: refs/heads/master@{#295948}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gin/modules/timer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 10 (3 generated)

ARUNKK

Added the DISALLOW_COPY_AND_ASSIGN(Timer); as per your suggestion in previous review (580703002). PTAL.

6 years, 3 months ago (2014-09-19 15:33:03 UTC) #2

ARUNKK

On 2014/09/22 09:53:11, jochen (slow for reviews) wrote: > lgtm Thanks for LGTM.

6 years, 3 months ago (2014-09-22 09:53:59 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587713002/1

6 years, 3 months ago (2014-09-22 09:54:44 UTC) #8

commit-bot: I haz the power

Committed patchset #1 (id:1) as f19452a10d312282fc76145e0c062a1d7f97902a

6 years, 3 months ago (2014-09-22 10:44:54 UTC) #9

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 10:45:33 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a3eab57adfb32b95e2cd5abf03b536c4a017aa95
Cr-Commit-Position: refs/heads/master@{#295948}