Ensure that hasPendingActivity() is false for stopped media elements

Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 3498 matching lines @@
 
 void HTMLMediaElement::stop()
 {
     WTF_LOG(Media, "HTMLMediaElement::stop(%p)", this);
 
     m_active = false;
     userCancelledLoad();
 
     // Stop the playback without generating events
     m_playing = false;
+    m_paused = true;
+    m_seeking = false;
     setPausedInternal(true);
 
     if (renderer())
         renderer()->updateFromElement();
 
     stopPeriodicTimers();
     cancelPendingEventsAndCallbacks();
 
     m_asyncEventQueue->close();
+
+    // Ensure that hasPendingActivity() is not preventing garbage collection, since otherwise this
+    // media element will simply leak.
+    ASSERT(!hasPendingActivity());
 }
 
 bool HTMLMediaElement::hasPendingActivity() const
 {
-    // After the document becomes inactive, no events can ever be fired.
-    if (!document().isActive())
-        return false;
-
     // The delaying-the-load-event flag is set by resource selection algorithm when looking for a
     // resource to load, before networkState has reached to NETWORK_LOADING.
     if (m_shouldDelayLoadEvent)
         return true;
 
     // When networkState is NETWORK_LOADING, progress and stalled events may be fired.
     if (m_networkState == NETWORK_LOADING)
         return true;
 
     // When playing or if playback may continue, timeupdate events may be fired.
@@ skipping 499 matching lines @@
 
 #if ENABLE(WEB_AUDIO)
 void HTMLMediaElement::clearWeakMembers(Visitor* visitor)
 {
     if (!visitor->isAlive(m_audioSourceNode) && audioSourceProvider())
         audioSourceProvider()->setClient(0);
 }
 #endif
 
 }