Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 587653003: Revert of mojo: fix python unittests. (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
Reviewers:
sdefresne, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: fix python unittests. (patchset #1 id:1 of https://codereview.chromium.org/586683002/) Reason for revert: Linux Tests mojo_python_bindings_tests failure http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13712 ====================================================================== ERROR: testDefaultsTestSerializationDeserialization (bindings_serialization_deserialization_unittest.SerializationDeserializationTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/bindings_serialization_deserialization_unittest.py", line 125, in testDefaultsTestSerializationDeserialization v2 = sample_service_mojom.DefaultsTest.Deserialize(data, handles) File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/reflection.py", line 113, in Deserialize serialization_object.Deserialize(fields, data, handles) File "/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/python/mojo/bindings/serialization.py", line 82, in Deserialize (_, version) = HEADER_STRUCT.unpack_from(data) TypeError: unpack_from() argument 1 must be string or read-only buffer, not bytearray Original issue's description: > mojo: fix python unittests. > > TBR=sdefresne@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/80ced42d624a1eec8e8a2f0c0c760ab576d65ead TBR=sdefresne@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/faf1182f5f24f3c86603d88ca78f2f4d02996eea Cr-Commit-Position: refs/heads/master@{#295688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/python/mojo/bindings/descriptor.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vasilii
Created Revert of mojo: fix python unittests.
6 years, 3 months ago (2014-09-19 12:23:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587653003/1
6 years, 3 months ago (2014-09-19 12:24:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7e69a835e86469f89c816b686038e7a25e513c99
6 years, 3 months ago (2014-09-19 12:24:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/faf1182f5f24f3c86603d88ca78f2f4d02996eea Cr-Commit-Position: refs/heads/master@{#295688}
6 years, 3 months ago (2014-09-19 12:25:01 UTC) #4
qsr
lgtm
6 years, 3 months ago (2014-09-19 12:49:33 UTC) #5
sdefresne
6 years, 3 months ago (2014-09-19 12:50:18 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698