Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 587623002: Introduce a class to carry around a deoptimization reason. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce a class to carry around a deoptimization reason. As discussed in https://codereview.chromium.org/582743002/, here a mechanical refactoring... R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24103

Patch Set 1 #

Patch Set 2 : Rebased. Re-added a few Comment calls which were accidentally removed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -105 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 chunk +13 lines, -13 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 5 chunks +30 lines, -29 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +9 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M src/lithium-codegen.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/lithium-codegen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 3 months ago (2014-09-19 11:24:28 UTC) #2
Jarin
lgtm
6 years, 3 months ago (2014-09-19 12:59:50 UTC) #3
Sven Panne
6 years, 3 months ago (2014-09-22 06:37:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24103 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698