Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 587613002: Do not special case the accept button of the time picker. (Closed)

Created:
6 years, 3 months ago by Miguel Garcia
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not special case the accept button of the time picker. BUG=412458 Committed: https://crrev.com/70ec8c25649bfc51ae1d9be126ce594ae1f10159 Cr-Commit-Position: refs/heads/master@{#295731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/InputDialogContainer.java View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Miguel Garcia
Can you click on the commit queue if you agree with the patch? It's fairly ...
6 years, 3 months ago (2014-09-19 10:18:36 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 3 months ago (2014-09-19 16:45:44 UTC) #3
aurimas (slooooooooow)
nyquist for OWNERS review
6 years, 3 months ago (2014-09-19 16:46:21 UTC) #5
nyquist
lgtm
6 years, 3 months ago (2014-09-19 16:55:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587613002/1
6 years, 3 months ago (2014-09-19 16:56:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as b3bc776fc1ed9415158ec3e2ce745fea7e18ae85
6 years, 3 months ago (2014-09-19 17:52:40 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 17:53:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70ec8c25649bfc51ae1d9be126ce594ae1f10159
Cr-Commit-Position: refs/heads/master@{#295731}

Powered by Google App Engine
This is Rietveld 408576698