Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 587543004: Revert of Reduce hit test on ShowPress by moving event targeting to WebViewImpl (Closed)

Created:
6 years, 3 months ago by Zeeshan Qureshi
Modified:
6 years, 3 months ago
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-events_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org, bokan, wjmaclean, mustaq
Project:
blink
Visibility:
Public.

Description

Revert of Reduce hit test on ShowPress by moving event targeting to WebViewImpl (patchset #11 id:240001 of https://codereview.chromium.org/490783003/) Reason for revert: Failing ContentShellTest on blink roll. http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/10536/ Original issue's description: > Reduce hit test on ShowPress by moving hit testing to WebViewImpl. > > Previously there was a hit test for link highlighting in WebViewImpl and then a > separate one in EventHandler::handleGestureEvent. This CL makes it so that a > single hit test in WebViewImpl is reused by the EventHandler. Scroll events > still need to hit test in a separate fashion though and their handling has been > refactored into a separate code path. > > BUG=381728 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182281 TBR=aelias@chromium.org,dgozman@chromium.org,rbyers@chromium.org NOTREECHECKS=true NOTRY=true BUG=381728 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -95 lines) Patch
M LayoutTests/compositing/gestures/gesture-tapHighlight-on-promoted-overflow-div-scrolled.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/hit-test-counts-expected.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/EventHandler.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 4 chunks +8 lines, -19 lines 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 7 chunks +39 lines, -49 lines 0 comments Download
M Source/web/tests/LinkHighlightTest.cpp View 4 chunks +31 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Zeeshan Qureshi
Created Revert of Reduce hit test on ShowPress by moving event targeting to WebViewImpl
6 years, 3 months ago (2014-09-19 16:32:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/587543004/1
6 years, 3 months ago (2014-09-19 16:33:03 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 16:33:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182340

Powered by Google App Engine
This is Rietveld 408576698