Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 587543003: Fix skia bug 2845 (Closed)

Created:
6 years, 3 months ago by kui.zheng
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix skia bug 2845 Shouldn't call Fast Blur path(DoubleRowBoxBlur_NEON) when kernelsize is 1. Or, uint16x8_t resultPixels will be overflow. BUG=skia:2845 R=senorblanco@chromium.org Committed: https://skia.googlesource.com/skia/+/b1629c5d9eb6236429cca1502d3bf5fcda8e3406

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/opts/SkBlitRow_opts_arm_neon.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/opts/SkBlurImage_opts_arm.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/opts/SkBlurImage_opts_neon.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
kui.zheng
6 years, 3 months ago (2014-09-19 02:56:55 UTC) #1
reed1
6 years, 3 months ago (2014-09-19 12:56:54 UTC) #3
hcm
On 2014/09/19 12:56:54, reed1 wrote: Adding Mike and Matt to help get this moving
5 years, 10 months ago (2015-02-12 16:57:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587543003/1
5 years, 10 months ago (2015-02-17 15:39:31 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-17 15:39:31 UTC) #8
msarett
lgtm
5 years, 10 months ago (2015-02-17 15:40:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587543003/1
5 years, 10 months ago (2015-02-17 15:42:28 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 16:01:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b1629c5d9eb6236429cca1502d3bf5fcda8e3406

Powered by Google App Engine
This is Rietveld 408576698