Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 587533002: Add missing fling_curve* entries to GN events targets. (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, scottmg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing fling_curve* entries to GN events targets. This is so it matches with GYP version. This was reported by http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/12122/steps/gyp_flag_compare/logs/stdio BUG=None TEST=gn gen out_gn/Debug && ninja -C out_gn/Debug events_base events_unittests R=brettw@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/6a528cdd4d2878e61fcd41aa2137c153398b822f Cr-Commit-Position: refs/heads/master@{#295881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ui/events/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tfarina
PTAL.
6 years, 3 months ago (2014-09-19 01:55:40 UTC) #1
tfarina
Ping. Scott, I need your approval for ui/. Thanks.
6 years, 3 months ago (2014-09-19 17:12:03 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-19 17:25:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587533002/1
6 years, 3 months ago (2014-09-19 20:31:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12244)
6 years, 3 months ago (2014-09-19 20:53:05 UTC) #8
tfarina
TBR sky for this.
6 years, 3 months ago (2014-09-20 17:40:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587533002/1
6 years, 3 months ago (2014-09-20 17:42:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 210575ec17dcaae32aff52df5dba15f0c096a335
6 years, 3 months ago (2014-09-20 17:48:34 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 17:49:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a528cdd4d2878e61fcd41aa2137c153398b822f
Cr-Commit-Position: refs/heads/master@{#295881}

Powered by Google App Engine
This is Rietveld 408576698