Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 587503002: More fixes to make 32 bit Linux builds pass compile. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

More fixes to make 32 bit Linux builds pass compile. This is breaking after r295514 which enforces that every file listed in an isolate file exists. BUG=414808 R=dbeam@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/7a39ec2c6bba3f577457e4f3bf807402cec365ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser_tests.isolate View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jam
6 years, 3 months ago (2014-09-19 01:26:06 UTC) #1
Dan Beam
i have no idea what i'm doing lgtm
6 years, 3 months ago (2014-09-19 01:27:03 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7a39ec2c6bba3f577457e4f3bf807402cec365ef Cr-Commit-Position: refs/heads/master@{#295636}
6 years, 3 months ago (2014-09-19 01:28:49 UTC) #4
jam
6 years, 3 months ago (2014-09-19 01:29:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 7a39ec2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698