Issue 587473003: Removed confusing defensive programming in GenerateJumpTable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587473003: Removed confusing defensive programming in GenerateJumpTable. (Closed)

Created:
6 years, 3 months ago by Sven Panne

Modified:
6 years, 3 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Removed confusing defensive programming in GenerateJumpTable. For a given address/type pair we should always find a deoptimization bailout ID, otherwise something is wrong. This was already asserted on ARM, but we now do this consistently on all platforms. Removed some usesless naming creativity on the way. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24077

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -48 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	src/arm64/lithium-codegen-arm64.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	src/mips64/lithium-codegen-mips64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips64/lithium-codegen-mips64.cc	View	3 chunks	+5 lines, -11 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sven Panne

6 years, 3 months ago (2014-09-19 11:07:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24077 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages