Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 587463002: checkperms: Recognize "#! /path" as a file that has a shabang. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

checkperms: Recognize "#! /path" as a file that has a shabang. Although uncommon, 294 files in /bin and /usr/bin has this pattern. Compared with 1300 files that starts with #!/path. Committed: https://crrev.com/4c04dfdb0fdc06ffe6bfb199a12b08fddc7eeb12 Cr-Commit-Position: refs/heads/master@{#295762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-5 lines, --5 lines) Patch
A third_party/cython/src/Tools/cython-epydoc.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/libxml/src/xml2-config.in View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/libxslt/compile View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/libxslt/linux/xslt-config View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/libxslt/xslt-config.in View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/checkperms/checkperms.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/json_schema_compiler/idl_schema.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
dzhioev: tools/ cpu: third_party/ (It's just all file permission changes, see the raw diff)
6 years, 3 months ago (2014-09-18 22:29:47 UTC) #2
dzhioev (left Google)
On 2014/09/18 22:29:47, Lei Zhang wrote: > dzhioev: tools/ > cpu: third_party/ (It's just all ...
6 years, 3 months ago (2014-09-19 00:52:45 UTC) #3
cpu_(ooo_6.6-7.5)
looks like existing libs, lgtm
6 years, 3 months ago (2014-09-19 18:19:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587463002/1
6 years, 3 months ago (2014-09-19 18:33:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 798eced109a130a6d2416832cb7f0563d1d36a03
6 years, 3 months ago (2014-09-19 19:25:47 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 19:27:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c04dfdb0fdc06ffe6bfb199a12b08fddc7eeb12
Cr-Commit-Position: refs/heads/master@{#295762}

Powered by Google App Engine
This is Rietveld 408576698