Cleanup: Remove some std::map::operator[] usage in ApiResourceManager.

Cleanup: Remove some std::map::operator[] usage in ApiResourceManager.

Also remove an unused header and add it where actually used.

Committed: https://crrev.com/f75586adc8cbec278d71b9177b5c91c91146d200
Cr-Commit-Position: refs/heads/master@{#295789}

[Lei Zhang, 2014-09-19 05:53:05]

thestig@chromium.org changed reviewers:
+ rockot@chromium.org

[Lei Zhang, 2014-09-19 05:53:06]

https://codereview.chromium.org/587453005/diff/1/extensions/browser/api/api_r...
File extensions/browser/api/api_resource_manager.h (left):

https://codereview.chromium.org/587453005/diff/1/extensions/browser/api/api_r...
extensions/browser/api/api_resource_manager.h:247:
DCHECK(extension_resource_map_.find(extension_id) !=
std::map::operator[] has the side effect of creating the |extension_id| mapping
if it didn't exist. So in real life, you can blow through this DCHECK without a
problem. In the new code, you'll get a crash and actually be alerted to DCHECK()
failures in production, if any.

[Ken Rockot(use gerrit already), 2014-09-19 16:37:06]

lgtm and thanks for the header changes as well

https://codereview.chromium.org/587453005/diff/1/extensions/browser/api/api_r...
File extensions/browser/api/api_resource_manager.h (left):

https://codereview.chromium.org/587453005/diff/1/extensions/browser/api/api_r...
extensions/browser/api/api_resource_manager.h:247:
DCHECK(extension_resource_map_.find(extension_id) !=
On 2014/09/19 05:53:05, Lei Zhang wrote:
> std::map::operator[] has the side effect of creating the |extension_id|
mapping
> if it didn't exist. So in real life, you can blow through this DCHECK without
a
> problem. In the new code, you'll get a crash and actually be alerted to
DCHECK()
> failures in production, if any.

Ah. Yeah. This is less a problem with operator[] and more a problem with putting
important program logic in DCHECKs.

But I don't like operator[] anyway, so... great!

[Lei Zhang, 2014-09-19 18:24:15]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-09-19 18:25:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/587453005/1

[commit-bot: I haz the power, 2014-09-19 22:01:43]

Committed patchset #1 (id:1) as 8f2a4f74b9d240dc2116ba94fe98a8698fc935db

[commit-bot: I haz the power, 2014-09-19 22:02:17]

Patchset 1 (id:??) landed as
https://crrev.com/f75586adc8cbec278d71b9177b5c91c91146d200
Cr-Commit-Position: refs/heads/master@{#295789}