Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 587433002: Roll Clang 216630:217949 (Closed)

Created:
6 years, 3 months ago by hans
Modified:
6 years, 2 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll Clang 216630:217949 Also make the script revert local changes before 'svn co' rather than afterwards to avoid merge conflicts if a previously patched file changes upstream. BUG=410810 Committed: https://crrev.com/ba4cf8bb6dc77ea033fe13989eb604d6069daa97 Cr-Commit-Position: refs/heads/master@{#296870}

Patch Set 1 #

Patch Set 2 : -Wno-unused-local-typedef #

Patch Set 3 : Rebase on #296776 #

Patch Set 4 : Remove redundant svn reverts #

Patch Set 5 : Fix the .gn file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -37 lines) Patch
M build/common.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 2 3 5 chunks +13 lines, -37 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
hans
Currently building new binaries after the rebase. Will run tryjobs once that's done.
6 years, 2 months ago (2014-09-25 20:26:17 UTC) #2
Nico
lgtm :-)
6 years, 2 months ago (2014-09-25 21:20:47 UTC) #3
hans
Tryjobs look good: the only failure is mac_asan64, which fails similarly on a whitespace change ...
6 years, 2 months ago (2014-09-25 23:40:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587433002/60001
6 years, 2 months ago (2014-09-25 23:43:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/19175) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13645) linux_chromium_gn_dbg ...
6 years, 2 months ago (2014-09-25 23:54:58 UTC) #8
hans
brettw: can you take an OWNERS look at the .gn file?
6 years, 2 months ago (2014-09-26 00:06:34 UTC) #10
brettw
lgtm
6 years, 2 months ago (2014-09-26 01:13:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587433002/80001
6 years, 2 months ago (2014-09-26 01:18:12 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 95f7d5aac479799d3b5ff5ff9d3224fe8dce32d7
6 years, 2 months ago (2014-09-26 03:12:58 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/ba4cf8bb6dc77ea033fe13989eb604d6069daa97 Cr-Commit-Position: refs/heads/master@{#296870}
6 years, 2 months ago (2014-09-26 03:13:44 UTC) #15
hans
6 years, 2 months ago (2014-09-26 23:45:05 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/614453002/ by hans@chromium.org.

The reason for reverting is: Reverting due to http://crbug.com/418234. Clang was
branching on undefined values..

Powered by Google App Engine
This is Rietveld 408576698