Importer - Change const char* foo to const char foo[]

chrome/browser/ui/webui/options/import_data_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/import_data_handler.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 165 matching lines @@
   base::ListValue browser_profiles;
   for (size_t i = 0; i < importer_list_->count(); ++i) {
     const importer::SourceProfile& source_profile =
         importer_list_->GetSourceProfileAt(i);
     uint16 browser_services = source_profile.services_supported;
 
     base::DictionaryValue* browser_profile = new base::DictionaryValue();
     browser_profile->SetString("name", source_profile.importer_name);
     browser_profile->SetInteger("index", i);
     browser_profile->SetBoolean("history",
-        (browser_services & importer::HISTORY) != 0);
+                                (browser_services & importer::HISTORY) != 0);
     browser_profile->SetBoolean("favorites",
-        (browser_services & importer::FAVORITES) != 0);
+                                (browser_services & importer::FAVORITES) != 0);
     browser_profile->SetBoolean("passwords",
-        (browser_services & importer::PASSWORDS) != 0);
-    browser_profile->SetBoolean("search",
-        (browser_services & importer::SEARCH_ENGINES) != 0);
-    browser_profile->SetBoolean("autofill-form-data",
+                                (browser_services & importer::PASSWORDS) != 0);
+    browser_profile->SetBoolean(
+        "search", (browser_services & importer::SEARCH_ENGINES) != 0);
+    browser_profile->SetBoolean(
+        "autofill-form-data",
         (browser_services & importer::AUTOFILL_FORM_DATA) != 0);
-
-    browser_profile->SetBoolean("show_bottom_bar",
+    browser_profile->SetBoolean(
+        "show_bottom_bar",

[Dan Beam, 2014/09/23 05:55:35]

if there's no functional change here (and it's just whitespace), i'd just revert
this file to the way it was.

[Nikhil, 2014/09/23 06:00:26]

Hmm, there is no functional change. But it was identified on an earlier CL to
run "git cl format" for these lines. Please see :
https://codereview.chromium.org/480953002/diff/20001/chrome/browser/ui/webui/...

Please let me know WDYT.

[Dan Beam, 2014/09/23 18:41:32]

it seems like it'd be pretty easy to run clang format on the whole codebase at
once if we really wanted to (but we haven't yet because it's not perfect).  for
instance, this pass actually adds 2 lines to the file and doesn't make the code
much easier to read :(.  it's also harder to find the original author of this
code when someone changes whitespace.

i'd still just revert

[Nikhil, 2014/09/29 06:10:43]

Acknowledged.

 #if defined(OS_MACOSX)
         source_profile.importer_type == importer::TYPE_SAFARI);
 #else
         false);
 #endif
 
     browser_profiles.Append(browser_profile);
   }
 
   web_ui()->CallJavascriptFunction("ImportDataOverlay.updateSupportedBrowsers",
@@ skipping 63 matching lines @@
                                   base::string16(),
                                   base::FilePath(),
                                   &file_type_info,
                                   0,
                                   base::FilePath::StringType(),
                                   browser->window()->GetNativeWindow(),
                                   NULL);
 }
 
 }  // namespace options