Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Side by Side Diff: Source/platform/RefCountedSupplement.h

Issue 587393002: Oilpan: make Supplementable tracing more regular. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve dummy trace() comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/workers/WorkerNavigator.cpp ('k') | Source/platform/Supplementable.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2012 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 class Wrapper FINAL : public Supplement<T> { 43 class Wrapper FINAL : public Supplement<T> {
44 public: 44 public:
45 explicit Wrapper(PassRefPtr<ThisType> wrapped) : m_wrapped(wrapped) { } 45 explicit Wrapper(PassRefPtr<ThisType> wrapped) : m_wrapped(wrapped) { }
46 virtual ~Wrapper() { } 46 virtual ~Wrapper() { }
47 #if ENABLE(SECURITY_ASSERT) 47 #if ENABLE(SECURITY_ASSERT)
48 virtual bool isRefCountedWrapper() const OVERRIDE { return true; } 48 virtual bool isRefCountedWrapper() const OVERRIDE { return true; }
49 #endif 49 #endif
50 ThisType* wrapped() const { return m_wrapped.get(); } 50 ThisType* wrapped() const { return m_wrapped.get(); }
51 51
52 virtual void trace(Visitor*) OVERRIDE { }
53
54 private: 52 private:
55 53
56 RefPtr<ThisType> m_wrapped; 54 RefPtr<ThisType> m_wrapped;
57 }; 55 };
58 56
59 static void provideTo(Supplementable<T>& host, const char* key, PassRefPtr<T hisType> supplement) 57 static void provideTo(Supplementable<T>& host, const char* key, PassRefPtr<T hisType> supplement)
60 { 58 {
61 host.provideSupplement(key, adoptPtr(new Wrapper(supplement))); 59 host.provideSupplement(key, adoptPtr(new Wrapper(supplement)));
62 } 60 }
63 61
64 static ThisType* from(Supplementable<T>& host, const char* key) 62 static ThisType* from(Supplementable<T>& host, const char* key)
65 { 63 {
66 Supplement<T>* found = static_cast<Supplement<T>*>(host.requireSupplemen t(key)); 64 Supplement<T>* found = static_cast<Supplement<T>*>(host.requireSupplemen t(key));
67 if (!found) 65 if (!found)
68 return 0; 66 return 0;
69 ASSERT_WITH_SECURITY_IMPLICATION(found->isRefCountedWrapper()); 67 ASSERT_WITH_SECURITY_IMPLICATION(found->isRefCountedWrapper());
70 return static_cast<Wrapper*>(found)->wrapped(); 68 return static_cast<Wrapper*>(found)->wrapped();
71 } 69 }
72 }; 70 };
73 #endif 71 #endif
74 72
75 } // namespace blink 73 } // namespace blink
76 74
77 #endif // RefCountedSupplement_h 75 #endif // RefCountedSupplement_h
OLDNEW
« no previous file with comments | « Source/core/workers/WorkerNavigator.cpp ('k') | Source/platform/Supplementable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698