Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: Source/core/frame/LocalFrame.cpp

Issue 587393002: Oilpan: make Supplementable tracing more regular. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve dummy trace() comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/frame/Navigator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 HashSet<RawPtr<FrameDestructionObserver> >::iterator stop = m_destructionObs ervers.end(); 137 HashSet<RawPtr<FrameDestructionObserver> >::iterator stop = m_destructionObs ervers.end();
138 for (HashSet<RawPtr<FrameDestructionObserver> >::iterator it = m_destruction Observers.begin(); it != stop; ++it) 138 for (HashSet<RawPtr<FrameDestructionObserver> >::iterator it = m_destruction Observers.begin(); it != stop; ++it)
139 (*it)->frameDestroyed(); 139 (*it)->frameDestroyed();
140 #endif 140 #endif
141 } 141 }
142 142
143 void LocalFrame::trace(Visitor* visitor) 143 void LocalFrame::trace(Visitor* visitor)
144 { 144 {
145 #if ENABLE(OILPAN) 145 #if ENABLE(OILPAN)
146 visitor->trace(m_destructionObservers); 146 visitor->trace(m_destructionObservers);
147 #endif
148 visitor->trace(m_loader); 147 visitor->trace(m_loader);
149 visitor->trace(m_navigationScheduler); 148 visitor->trace(m_navigationScheduler);
150 visitor->trace(m_pagePopupOwner); 149 visitor->trace(m_pagePopupOwner);
151 visitor->trace(m_editor); 150 visitor->trace(m_editor);
152 visitor->trace(m_spellChecker); 151 visitor->trace(m_spellChecker);
153 visitor->trace(m_selection); 152 visitor->trace(m_selection);
154 visitor->trace(m_eventHandler); 153 visitor->trace(m_eventHandler);
155 visitor->trace(m_console); 154 visitor->trace(m_console);
156 visitor->trace(m_inputMethodController); 155 visitor->trace(m_inputMethodController);
156 HeapSupplementable<LocalFrame>::trace(visitor);
157 #endif
157 Frame::trace(visitor); 158 Frame::trace(visitor);
158 WillBeHeapSupplementable<LocalFrame>::trace(visitor);
159 } 159 }
160 160
161 void LocalFrame::detach() 161 void LocalFrame::detach()
162 { 162 {
163 // A lot of the following steps can result in the current frame being 163 // A lot of the following steps can result in the current frame being
164 // detached, so protect a reference to it. 164 // detached, so protect a reference to it.
165 RefPtrWillBeRawPtr<LocalFrame> protect(this); 165 RefPtrWillBeRawPtr<LocalFrame> protect(this);
166 m_loader.stopAllLoaders(); 166 m_loader.stopAllLoaders();
167 m_loader.closeURL(); 167 m_loader.closeURL();
168 detachChildren(); 168 detachChildren();
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
733 733
734 return curFrame; 734 return curFrame;
735 } 735 }
736 736
737 void LocalFrame::setPagePopupOwner(Element& owner) 737 void LocalFrame::setPagePopupOwner(Element& owner)
738 { 738 {
739 m_pagePopupOwner = &owner; 739 m_pagePopupOwner = &owner;
740 } 740 }
741 741
742 } // namespace blink 742 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/frame/Navigator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698