Chromium Code Reviews Chromium Code Reviews
Issue 587393002:
Oilpan: make Supplementable tracing more regular. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2013 Google Inc. All rights reserved. | 2 * Copyright (C) 2013 Google Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are |
| 6 * met: | 6 * met: |
| 7 * | 7 * |
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright |
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. |
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above |
| (...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 43 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WorkerClients); | 43 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WorkerClients); |
| 44 WTF_MAKE_NONCOPYABLE(WorkerClients); | 44 WTF_MAKE_NONCOPYABLE(WorkerClients); |
| 45 public: | 45 public: |
| 46 static PassOwnPtrWillBeRawPtr<WorkerClients> create() | 46 static PassOwnPtrWillBeRawPtr<WorkerClients> create() |
| 47 { | 47 { |
| 48 return adoptPtrWillBeNoop(new WorkerClients()); | 48 return adoptPtrWillBeNoop(new WorkerClients()); |
| 49 } | 49 } |
| 50 | 50 |
| 51 virtual ~WorkerClients() { } | 51 virtual ~WorkerClients() { } |
| 52 | 52 |
| 53 #if ENABLE(OILPAN) | |
|
haraken
2014/09/23 02:33:46
We normally add #if to inside the trace method.
sof
2014/09/23 05:21:07
Yes, the reason for not doing so here is to avoid
| |
| 53 virtual void trace(Visitor* visitor) OVERRIDE | 54 virtual void trace(Visitor* visitor) OVERRIDE |
| 54 { | 55 { |
| 55 WillBeHeapSupplementable<WorkerClients>::trace(visitor); | 56 HeapSupplementable<WorkerClients>::trace(visitor); |
| 56 } | 57 } |
| 58 #endif | |
| 57 | 59 |
| 58 private: | 60 private: |
| 59 WorkerClients() { } | 61 WorkerClients() { } |
| 60 }; | 62 }; |
| 61 | 63 |
| 62 } // namespace blink | 64 } // namespace blink |
| 63 | 65 |
| 64 #endif // WorkerClients_h | 66 #endif // WorkerClients_h |
| OLD | NEW |
