Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 587363002: Fix IC cache confusion on String.prototype.length (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev, Toon Verwaest
Project:
v8
Visibility:
Public.

Description

Fix IC cache confusion on String.prototype.length BUG=416416 LOG=N R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/ic/ic.cc View 1 chunk +8 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-416416.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Jarin, Here is the CL for the issue we worked on. Thanks! --Michael
6 years, 3 months ago (2014-09-22 13:31:16 UTC) #1
mvstanton
(Oops I mean Jaroslav :D)
6 years, 3 months ago (2014-09-22 13:31:36 UTC) #2
Jarin
lgtm
6 years, 3 months ago (2014-09-22 14:58:58 UTC) #3
mvstanton
6 years, 3 months ago (2014-09-24 09:33:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24174 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698