Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 587293002: Add fileSystemProvider API extension example. (Closed)

Created:
6 years, 3 months ago by cmihail
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add fileSystemProvider API extension example. A simple cloud extension example that uses the file system provider API This example is different from https://codereview.chromium.org/360673004 as it is an extension and not an app. BUG=415847 R=mtomasz@chromium.org Committed: https://crrev.com/d5dfc9a8499bc06b5f0d349448824a7ba5d53e08 Cr-Commit-Position: refs/heads/master@{#296579}

Patch Set 1 #

Patch Set 2 : Change basic example to a extension from app. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/common/extensions/docs/examples/api/fileSystemProvider/archive/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/fileSystemProvider/basic/manifest.json View 1 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
cmihail
6 years, 3 months ago (2014-09-22 11:58:41 UTC) #1
mtomasz
It seems that after enabling FSP API for extensions, the previous examples show up also ...
6 years, 2 months ago (2014-09-24 01:05:48 UTC) #2
cmihail
On 2014/09/24 01:05:48, mtomasz wrote: > It seems that after enabling FSP API for extensions, ...
6 years, 2 months ago (2014-09-24 05:19:39 UTC) #3
mtomasz
lgtm
6 years, 2 months ago (2014-09-24 05:21:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587293002/20001
6 years, 2 months ago (2014-09-24 05:24:03 UTC) #6
cmihail
On 2014/09/24 05:21:32, mtomasz wrote: > lgtm I need also Kalman's ltgm no?
6 years, 2 months ago (2014-09-24 05:24:52 UTC) #7
mtomasz
On 2014/09/24 05:24:52, cmihail wrote: > On 2014/09/24 05:21:32, mtomasz wrote: > > lgtm > ...
6 years, 2 months ago (2014-09-24 05:31:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13057)
6 years, 2 months ago (2014-09-24 05:33:25 UTC) #10
cmihail
On 2014/09/24 05:33:25, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-24 05:34:39 UTC) #11
cmihail
On 2014/09/24 05:33:25, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-24 05:34:39 UTC) #12
cmihail
On 2014/09/24 05:34:39, cmihail wrote: > On 2014/09/24 05:33:25, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-09-24 06:35:56 UTC) #14
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-09-24 14:38:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587293002/20001
6 years, 2 months ago (2014-09-24 23:55:53 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c61294163d465bb02a8990867aa77c61b224a084
6 years, 2 months ago (2014-09-25 00:01:55 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 00:02:30 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5dfc9a8499bc06b5f0d349448824a7ba5d53e08
Cr-Commit-Position: refs/heads/master@{#296579}

Powered by Google App Engine
This is Rietveld 408576698