Issue 587253005: Use CheckCallAndFilterAndHeader for git commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587253005: Use CheckCallAndFilterAndHeader for git commands. (Closed)

Created:
6 years, 3 months ago by Sam Clegg

Modified:
6 years, 3 months ago

Reviewers:
szager1

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Project:
tools

Visibility:
Public.

Use CheckCallAndFilterAndHeader for git commands. Then this was changed to CheckCallAndFilter it broke the expectations of code in the buildbot tree: scripts/slave/chromium_commands.py:extract_revisions Alternatively we could update the expectations of chromium_commands.py. BUG= https://code.google.com/p/chromium/issues/detail?id=412818 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292072

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	gclient_scm.py	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	tests/gclient_scm_test.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

Sam Clegg

Not sure why this was changed, or if there is better fix.

6 years, 3 months ago (2014-09-22 19:06:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587253005/20001

6 years, 3 months ago (2014-09-22 21:15:40 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 21:18:01 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 292072