Issue 587243004: Remove more keyboard usability related code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587243004: Remove more keyboard usability related code (Closed)

Created:
6 years, 3 months ago by bshe

Modified:
6 years, 3 months ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove more keyboard usability related code BUG=414766 Committed: https://crrev.com/e1eb0a2db824ecdfb3098b26a629c186b969a399 Cr-Commit-Position: refs/heads/master@{#296250}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -19 lines)			Patch
M	ash/display/display_controller.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/root_window_controller.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	ash/root_window_controller.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download

Total messages: 7 (2 generated)

bshe

Hey Oshima. Here is another simple CL for you to review. I just removed more ...

6 years, 3 months ago (2014-09-22 22:25:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587243004/1

6 years, 3 months ago (2014-09-23 21:03:25 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as d70bb7908bb5847260c122670669edca648621b4

6 years, 3 months ago (2014-09-23 21:18:44 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-23 21:19:41 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e1eb0a2db824ecdfb3098b26a629c186b969a399
Cr-Commit-Position: refs/heads/master@{#296250}