Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/arm64/lithium-codegen-arm64.cc

Issue 587223002: Emit source positions in deopt comments, too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/deoptimizer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm64/lithium-codegen-arm64.h" 7 #include "src/arm64/lithium-codegen-arm64.h"
8 #include "src/arm64/lithium-gap-resolver-arm64.h" 8 #include "src/arm64/lithium-gap-resolver-arm64.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1026 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 __ Pop(x2, x1, x0); 1037 __ Pop(x2, x1, x0);
1038 } 1038 }
1039 1039
1040 if (info()->ShouldTrapOnDeopt()) { 1040 if (info()->ShouldTrapOnDeopt()) {
1041 Label dont_trap; 1041 Label dont_trap;
1042 __ B(&dont_trap, InvertBranchType(branch_type), reg, bit); 1042 __ B(&dont_trap, InvertBranchType(branch_type), reg, bit);
1043 __ Debug("trap_on_deopt", __LINE__, BREAK); 1043 __ Debug("trap_on_deopt", __LINE__, BREAK);
1044 __ Bind(&dont_trap); 1044 __ Bind(&dont_trap);
1045 } 1045 }
1046 1046
1047 Deoptimizer::Reason reason(instr->Mnemonic(), detail); 1047 Deoptimizer::Reason reason(instr->hydrogen_value()->position().raw(),
1048 instr->Mnemonic(), detail);
1048 DCHECK(info()->IsStub() || frame_is_built_); 1049 DCHECK(info()->IsStub() || frame_is_built_);
1049 // Go through jump table if we need to build frame, or restore caller doubles. 1050 // Go through jump table if we need to build frame, or restore caller doubles.
1050 if (branch_type == always && 1051 if (branch_type == always &&
1051 frame_is_built_ && !info()->saves_caller_doubles()) { 1052 frame_is_built_ && !info()->saves_caller_doubles()) {
1052 DeoptComment(reason); 1053 DeoptComment(reason);
1053 __ Call(entry, RelocInfo::RUNTIME_ENTRY); 1054 __ Call(entry, RelocInfo::RUNTIME_ENTRY);
1054 } else { 1055 } else {
1055 // We often have several deopts to the same entry, reuse the last 1056 // We often have several deopts to the same entry, reuse the last
1056 // jump entry if this is the case. 1057 // jump entry if this is the case.
1057 if (jump_table_.is_empty() || (jump_table_.last()->address != entry) || 1058 if (jump_table_.is_empty() || (jump_table_.last()->address != entry) ||
(...skipping 4980 matching lines...) Expand 10 before | Expand all | Expand 10 after
6038 Handle<ScopeInfo> scope_info = instr->scope_info(); 6039 Handle<ScopeInfo> scope_info = instr->scope_info();
6039 __ Push(scope_info); 6040 __ Push(scope_info);
6040 __ Push(ToRegister(instr->function())); 6041 __ Push(ToRegister(instr->function()));
6041 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6042 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6042 RecordSafepoint(Safepoint::kNoLazyDeopt); 6043 RecordSafepoint(Safepoint::kNoLazyDeopt);
6043 } 6044 }
6044 6045
6045 6046
6046 6047
6047 } } // namespace v8::internal 6048 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/deoptimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698