Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 587223002: Emit source positions in deopt comments, too. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-codegen-arm.h" 7 #include "src/arm/lithium-codegen-arm.h"
8 #include "src/arm/lithium-gap-resolver-arm.h" 8 #include "src/arm/lithium-gap-resolver-arm.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 if (condition != al) { 892 if (condition != al) {
893 condition = ne; 893 condition = ne;
894 __ cmp(scratch, Operand::Zero()); 894 __ cmp(scratch, Operand::Zero());
895 } 895 }
896 } 896 }
897 897
898 if (info()->ShouldTrapOnDeopt()) { 898 if (info()->ShouldTrapOnDeopt()) {
899 __ stop("trap_on_deopt", condition); 899 __ stop("trap_on_deopt", condition);
900 } 900 }
901 901
902 Deoptimizer::Reason reason(instr->Mnemonic(), detail); 902 Deoptimizer::Reason reason(instr->hydrogen_value()->position().raw(),
903 instr->Mnemonic(), detail);
903 DCHECK(info()->IsStub() || frame_is_built_); 904 DCHECK(info()->IsStub() || frame_is_built_);
904 // Go through jump table if we need to handle condition, build frame, or 905 // Go through jump table if we need to handle condition, build frame, or
905 // restore caller doubles. 906 // restore caller doubles.
906 if (condition == al && frame_is_built_ && 907 if (condition == al && frame_is_built_ &&
907 !info()->saves_caller_doubles()) { 908 !info()->saves_caller_doubles()) {
908 DeoptComment(reason); 909 DeoptComment(reason);
909 __ Call(entry, RelocInfo::RUNTIME_ENTRY); 910 __ Call(entry, RelocInfo::RUNTIME_ENTRY);
910 } else { 911 } else {
911 // We often have several deopts to the same entry, reuse the last 912 // We often have several deopts to the same entry, reuse the last
912 // jump entry if this is the case. 913 // jump entry if this is the case.
(...skipping 4998 matching lines...) Expand 10 before | Expand all | Expand 10 after
5911 __ Push(scope_info); 5912 __ Push(scope_info);
5912 __ push(ToRegister(instr->function())); 5913 __ push(ToRegister(instr->function()));
5913 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5914 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5914 RecordSafepoint(Safepoint::kNoLazyDeopt); 5915 RecordSafepoint(Safepoint::kNoLazyDeopt);
5915 } 5916 }
5916 5917
5917 5918
5918 #undef __ 5919 #undef __
5919 5920
5920 } } // namespace v8::internal 5921 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698