Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 587213003: [ServiceWorker] Plumbing the request mode from the renderer to the ServiceWorker. [1/2 blink]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 587213003: [ServiceWorker] Plumbing the request mode from the renderer to the ServiceWorker. [1/2 blink] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: wrap in 80 columns Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/exported/WebServiceWorkerRequest.cpp ('K') | « Source/platform/network/ResourceRequestTest.cpp ('k') | public/platform/WebServiceWorkerRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index e26077c45dad791afbcc00cec018c2abfa0887bd..0c3a6d34549895ed946c7b8bce4da446d367e5ae 100644

--- a/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -84,7 +84,7 @@ void ServiceWorkerGlobalScopeProxy::dispatchActivateEvent(int eventID)

void ServiceWorkerGlobalScopeProxy::dispatchFetchEvent(int eventID, const WebServiceWorkerRequest& webRequest)

{

ASSERT(m_workerGlobalScope);

- RespondWithObserver* observer = RespondWithObserver::create(m_workerGlobalScope, eventID);

+ RespondWithObserver* observer = RespondWithObserver::create(m_workerGlobalScope, eventID, webRequest.mode());

if (!RuntimeEnabledFeatures::serviceWorkerOnFetchEnabled()) {

observer->didDispatchEvent();

return;