Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 587213002: Fix serializing ICs. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add TODO #

Patch Set 4 : rebased #

Total comments: 2

Patch Set 5 : added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M src/builtins.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/serialize.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 2 3 2 chunks +22 lines, -18 lines 0 comments Download
A + test/mjsunit/serialize-ic.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 3 months ago (2014-09-22 08:31:33 UTC) #1
Yang
On 2014/09/22 08:31:33, Yang wrote: The CL on which this one depends landed, so I ...
6 years, 2 months ago (2014-09-25 07:39:00 UTC) #2
mvstanton
LGTM, just give me that TODO, because this whole NoCache thing in the MajorKey makes ...
6 years, 2 months ago (2014-09-26 12:36:52 UTC) #3
Yang
https://codereview.chromium.org/587213002/diff/60001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/587213002/diff/60001/src/code-stubs.h#newcode139 src/code-stubs.h:139: NoCache = 0, // marker for stubs that do ...
6 years, 2 months ago (2014-09-26 13:51:01 UTC) #4
Yang
6 years, 2 months ago (2014-09-29 07:14:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 24262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698