Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: src/ic/ia32/handler-compiler-ia32.cc

Issue 587203002: ExtendStorageStub added, it is aimed for extending objects backing store when it runs out of space. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 __ movsd(FieldOperand(storage_reg, HeapNumber::kValueOffset), xmm0); 383 __ movsd(FieldOperand(storage_reg, HeapNumber::kValueOffset), xmm0);
384 } 384 }
385 385
386 // Stub never generated for objects that require access checks. 386 // Stub never generated for objects that require access checks.
387 DCHECK(!transition->is_access_check_needed()); 387 DCHECK(!transition->is_access_check_needed());
388 388
389 // Perform map transition for the receiver if necessary. 389 // Perform map transition for the receiver if necessary.
390 if (details.type() == FIELD && 390 if (details.type() == FIELD &&
391 Map::cast(transition->GetBackPointer())->unused_property_fields() == 0) { 391 Map::cast(transition->GetBackPointer())->unused_property_fields() == 0) {
392 // The properties must be extended before we can store the value. 392 // The properties must be extended before we can store the value.
393 // We jump to a runtime call that extends the properties array. 393 __ mov(ExtendStorageDescriptor::NameRegister(), Immediate(name));
394 __ pop(scratch1); // Return address. 394 __ mov(ExtendStorageDescriptor::MapRegister(), Immediate(transition));
395 __ push(receiver_reg); 395
396 __ push(Immediate(transition)); 396 ExtendStorageStub stub(isolate(),
397 __ push(value_reg); 397 FieldIndex::ForDescriptor(*transition, descriptor),
398 __ push(scratch1); 398 representation);
399 __ TailCallExternalReference( 399 GenerateTailCall(masm(), stub.GetCode());
400 ExternalReference(IC_Utility(IC::kSharedStoreIC_ExtendStorage),
401 isolate()),
402 3, 1);
403 return; 400 return;
404 } 401 }
405 402
406 // Update the map of the object. 403 // Update the map of the object.
407 __ mov(scratch1, Immediate(transition)); 404 __ mov(scratch1, Immediate(transition));
408 __ mov(FieldOperand(receiver_reg, HeapObject::kMapOffset), scratch1); 405 __ mov(FieldOperand(receiver_reg, HeapObject::kMapOffset), scratch1);
409 406
410 // Update the write barrier for the map field. 407 // Update the write barrier for the map field.
411 __ RecordWriteField(receiver_reg, HeapObject::kMapOffset, scratch1, scratch2, 408 __ RecordWriteField(receiver_reg, HeapObject::kMapOffset, scratch1, scratch2,
412 kDontSaveFPRegs, OMIT_REMEMBERED_SET, OMIT_SMI_CHECK); 409 kDontSaveFPRegs, OMIT_REMEMBERED_SET, OMIT_SMI_CHECK);
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 // Return the generated code. 841 // Return the generated code.
845 return GetCode(kind(), Code::NORMAL, name); 842 return GetCode(kind(), Code::NORMAL, name);
846 } 843 }
847 844
848 845
849 #undef __ 846 #undef __
850 } 847 }
851 } // namespace v8::internal 848 } // namespace v8::internal
852 849
853 #endif // V8_TARGET_ARCH_IA32 850 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698