Issue 587193004: [X11] Removing dependency from GN file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587193004: [X11] Removing dependency from GN file (Closed)

Created:
6 years, 3 months ago by Mathieu

Modified:
6 years, 3 months ago

Reviewers:
kpschoedel

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[Sheriffing] Removing dependency from GN file Previous change forgot to remove a file from BUILD.gn https://codereview.chromium.org/479873002 BUG=None NOTRY=true TBR=jam Committed: https://crrev.com/5b9cc021f78daca0fe7dfd666dedaeeecb67f849 Cr-Commit-Position: refs/heads/master@{#295966}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	content/browser/BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587193004/1

6 years, 3 months ago (2014-09-22 14:29:04 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 14a64dae9103d878934320c516e7186a2b224cab

6 years, 3 months ago (2014-09-22 14:29:25 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 14:29:59 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5b9cc021f78daca0fe7dfd666dedaeeecb67f849
Cr-Commit-Position: refs/heads/master@{#295966}