Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 587193002: dmprof expand command supports to analyze unhooked components (Closed)

Created:
6 years, 3 months ago by wensheng
Modified:
6 years, 3 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, dmikurube+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

dmprof expand command supports to analyze unhooked components Currently when analyze the memory usage details of the unhooked components, like unhooked-other, the dmprof expand command does nothing. The purpose of this patch is to enhance 'dmprof expand' command. As unhooked maps have no call stack traces, the result just filters MMAP_LIST items in *.heap files, which belongs to current component specified by the command parameter. R=kouhei@chromium.org BUG=416314 Committed: https://crrev.com/0599b1455f1dd12b002dc618df23cada5fec345f Cr-Commit-Position: refs/heads/master@{#295943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M tools/deep_memory_profiler/subcommands/expand.py View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
wensheng
6 years, 3 months ago (2014-09-22 07:29:39 UTC) #1
kouhei (in TOK)
Change looks ok to me. Would you elabolate on description? Thanks.
6 years, 3 months ago (2014-09-22 07:31:27 UTC) #2
wensheng
On 2014/09/22 07:31:27, kouhei wrote: > Change looks ok to me. Would you elabolate on ...
6 years, 3 months ago (2014-09-22 08:28:22 UTC) #3
kouhei (in TOK)
On 2014/09/22 08:28:22, wensheng wrote: > On 2014/09/22 07:31:27, kouhei wrote: > > Change looks ...
6 years, 3 months ago (2014-09-22 08:29:42 UTC) #4
wensheng
On 2014/09/22 08:29:42, kouhei wrote: > On 2014/09/22 08:28:22, wensheng wrote: > > On 2014/09/22 ...
6 years, 3 months ago (2014-09-22 08:42:24 UTC) #5
kouhei (in TOK)
lgtm
6 years, 3 months ago (2014-09-22 09:05:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587193002/1
6 years, 3 months ago (2014-09-22 09:05:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5aeba7e465f9ecc7e3a8429c2f0ba0f8362f9e13
6 years, 3 months ago (2014-09-22 09:41:42 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 09:42:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0599b1455f1dd12b002dc618df23cada5fec345f
Cr-Commit-Position: refs/heads/master@{#295943}

Powered by Google App Engine
This is Rietveld 408576698