Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 587173008: move build flags into chrome's SkUserConfig (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

move build flags into chrome's SkUserConfig BUG= Committed: https://crrev.com/568777ccc9dd7259df3286917aaa1e8d3df5f7d6 Cr-Commit-Position: refs/heads/master@{#295971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +37 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
Current state of skia_for_chromium.gypi 'skia_for_chromium_defines': [ 'SK_SUPPORT_LEGACY_PUBLIC_IMAGEINFO_FIELDS', 'SK_IGNORE_PROPER_FRACTIONAL_SCALING', 'SK_SUPPORT_LEGACY_PICTURE_CLONE', 'SK_IGNORE_ETC1_SUPPORT', 'SK_IGNORE_GPU_DITHER', 'SK_SUPPORT_LEGACY_IMAGECACHE_NAME', 'SK_LEGACY_PICTURE_SIZE_API', 'SK_LEGACY_PICTURE_DRAW_API', ], ...
6 years, 3 months ago (2014-09-22 13:33:26 UTC) #2
f(malita)
lgtm
6 years, 3 months ago (2014-09-22 13:36:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587173008/1
6 years, 3 months ago (2014-09-22 13:38:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6ae820d2ce866fb2956c24029fcc826080affacb
6 years, 3 months ago (2014-09-22 14:51:28 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 14:52:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/568777ccc9dd7259df3286917aaa1e8d3df5f7d6
Cr-Commit-Position: refs/heads/master@{#295971}

Powered by Google App Engine
This is Rietveld 408576698