Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 587173004: Add media_unittests to chromium_builder_webrtc GYP target. (Closed)

Created:
6 years, 3 months ago by kjellander_chromium
Modified:
6 years, 3 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add media_unittests to chromium_builder_webrtc GYP target. Also depend on chromium_builder_perf instead of chromium_builder_qa since it's likely we'll start running Telemetry tests on our bots in the near future. BUG= Committed: https://crrev.com/88f639b44ae2bb400ce3407c127ed57565662ef0 Cr-Commit-Position: refs/heads/master@{#295968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M build/all.gyp View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
6 years, 3 months ago (2014-09-22 09:05:06 UTC) #2
phoglund_chromium
lgtm
6 years, 3 months ago (2014-09-22 13:08:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587173004/1
6 years, 3 months ago (2014-09-22 13:12:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d1376d8f06741710e0021f265632bef8864282ec
6 years, 3 months ago (2014-09-22 14:32:59 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 14:33:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88f639b44ae2bb400ce3407c127ed57565662ef0
Cr-Commit-Position: refs/heads/master@{#295968}

Powered by Google App Engine
This is Rietveld 408576698