Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: mojo/system/proxy_message_pipe_endpoint.h

Issue 587153003: Mojo: Move the paused message queue from ProxyMessagePipeEndpoint to ChannelEndpoint. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@del_pmpe_attach
Patch Set: rebased Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/message_pipe.cc ('k') | mojo/system/proxy_message_pipe_endpoint.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/proxy_message_pipe_endpoint.h
diff --git a/mojo/system/proxy_message_pipe_endpoint.h b/mojo/system/proxy_message_pipe_endpoint.h
index fdc5e7265a3fcabd77416c14ef4e625512a85be6..04723a2f17b91efeee69d9ec9ff4410965a433ba 100644
--- a/mojo/system/proxy_message_pipe_endpoint.h
+++ b/mojo/system/proxy_message_pipe_endpoint.h
@@ -8,7 +8,6 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "mojo/system/message_in_transit.h"
-#include "mojo/system/message_in_transit_queue.h"
#include "mojo/system/message_pipe_endpoint.h"
#include "mojo/system/system_impl_export.h"
@@ -38,13 +37,11 @@ class MOJO_SYSTEM_IMPL_EXPORT ProxyMessagePipeEndpoint
: public MessagePipeEndpoint {
public:
explicit ProxyMessagePipeEndpoint(ChannelEndpoint* channel_endpoint);
- // Constructs a |ProxyMessagePipeEndpoint| that replaces the given
- // |LocalMessagePipeEndpoint| (which this constructor will close), taking its
- // message queue's contents. This is done when transferring a message pipe
- // handle over a remote message pipe.
+ // Constructs a |ProxyMessagePipeEndpoint|, whose peer may already be closed.
+ // This is used to construct one to replace a |LocalMessagePipeEndpoint|, when
+ // transferring a message pipe handle over a remote message pipe.
ProxyMessagePipeEndpoint(
ChannelEndpoint* channel_endpoint,
- LocalMessagePipeEndpoint* local_message_pipe_endpoint,
bool is_peer_open);
virtual ~ProxyMessagePipeEndpoint();
@@ -70,10 +67,6 @@ class MOJO_SYSTEM_IMPL_EXPORT ProxyMessagePipeEndpoint
bool is_peer_open_;
- // This queue is only used while we're detached, to store messages while we're
- // not ready to send them yet.
- MessageInTransitQueue paused_message_queue_;
-
DISALLOW_COPY_AND_ASSIGN(ProxyMessagePipeEndpoint);
};
« no previous file with comments | « mojo/system/message_pipe.cc ('k') | mojo/system/proxy_message_pipe_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698