Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 587133002: Retire obsolete DrMemory suppressions ..122245b (Closed)

Created:
6 years, 3 months ago by Eric Willigers
Modified:
6 years, 2 months ago
Reviewers:
Derek Bruening
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Retire obsolete DrMemory suppressions ..122245b These have recently been retired from Valgrind, and are also being retired from Dr Memory: bug_108147 bug_108620 bug_109496 bug_116475 bug_122245a bug_122245b BUG=108147, 108620, 109496, 116475, 122245 R=bruening@chromium.org NOTRY=true Committed: https://crrev.com/b0c42aff39525daf04779cb1a22b935ea7c42d5a Cr-Commit-Position: refs/heads/master@{#296105}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 2 chunks +0 lines, -74 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Eric Willigers
6 years, 3 months ago (2014-09-22 05:37:15 UTC) #1
Derek Bruening
LGTM
6 years, 2 months ago (2014-09-22 19:03:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587133002/1
6 years, 2 months ago (2014-09-22 20:46:54 UTC) #4
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/drmemory/suppressions_full.txt: While running git apply --index -p1; error: patch failed: ...
6 years, 2 months ago (2014-09-22 20:49:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587133002/20001
6 years, 2 months ago (2014-09-23 00:24:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as bfcdcf59fb30fe36595ae50e7c03ef885906173f
6 years, 2 months ago (2014-09-23 00:25:00 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-23 00:25:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0c42aff39525daf04779cb1a22b935ea7c42d5a
Cr-Commit-Position: refs/heads/master@{#296105}

Powered by Google App Engine
This is Rietveld 408576698