Issue 587103002: GCP 2.0 prototype switches code cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587103002: GCP 2.0 prototype switches code cleanup. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 3 months ago

Reviewers:
gene

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

GCP 2.0 prototype switches code cleanup. TBR=gene@chromium.org Committed: https://crrev.com/8e5841144fb76fa5f3d55f2a6f1e37f013fd661a Cr-Commit-Position: refs/heads/master@{#295925}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -50 lines)			Patch
M	cloud_print/gcp20/prototype/command_line_reader.cc	View	4 chunks	+11 lines, -13 lines	0 comments	Download
M	cloud_print/gcp20/prototype/dns_sd_server.cc	View	5 chunks	+6 lines, -4 lines	0 comments	Download
M	cloud_print/gcp20/prototype/gcp20_device.cc	View	2 chunks	+4 lines, -31 lines	0 comments	Download
M	cloud_print/gcp20/prototype/gcp20_device.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	cloud_print/gcp20/prototype/gcp20_switches.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	cloud_print/gcp20/prototype/gcp20_switches.cc	View	1 chunk	+63 lines, -0 lines	0 comments	Download
M	cloud_print/gcp20/prototype/print_job_handler.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	cloud_print/gcp20/prototype/privet_http_server.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587103002/20001

6 years, 3 months ago (2014-09-22 04:22:30 UTC) #3

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 609aee4039aedbe16fb539e6767f80143e657668

6 years, 3 months ago (2014-09-22 04:53:32 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-22 04:54:08 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/8e5841144fb76fa5f3d55f2a6f1e37f013fd661a
Cr-Commit-Position: refs/heads/master@{#295925}