Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 587013003: Add Print Preview UI to accept and reject printer sharing invitations. (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Print Preview UI to accept and reject printer sharing invitations. BUG=397741 Committed: https://crrev.com/67d48589922934fe3ea0bd34a4d8a9cd433b4ea9 Cr-Commit-Position: refs/heads/master@{#295932}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 13 (5 generated)
Aleksey Shlyapnikov
6 years, 3 months ago (2014-09-21 21:51:07 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/587013003/diff/1/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/587013003/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#newcode858 chrome/browser/resources/print_preview/data/destination_store.js:858: event.printer.isRecent = true; Please add metricts somewhere to ...
6 years, 3 months ago (2014-09-22 01:25:15 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm lgtm https://codereview.chromium.org/587013003/diff/1/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/587013003/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#newcode858 chrome/browser/resources/print_preview/data/destination_store.js:858: event.printer.isRecent = true; Please add metricts somewhere ...
6 years, 3 months ago (2014-09-22 01:25:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587013003/1
6 years, 3 months ago (2014-09-22 01:26:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/16447)
6 years, 3 months ago (2014-09-22 02:32:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/587013003/1
6 years, 3 months ago (2014-09-22 06:08:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 648feeb3b7ec2e253b3e2f86948dc96152b18eb9
6 years, 3 months ago (2014-09-22 07:08:40 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 07:09:10 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/67d48589922934fe3ea0bd34a4d8a9cd433b4ea9
Cr-Commit-Position: refs/heads/master@{#295932}

Powered by Google App Engine
This is Rietveld 408576698