Chromium Code Reviews
Help | Chromium Project | Sign in
(23)

Issue 5870001: Last few NewRunnableMethod scoped_refptr params to fix. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by willchan
Modified:
2 years, 11 months ago
Reviewers:
Alpha, Nico, scherkus
CC:
chromium-reviews_chromium.org, Victoria Kirst, fbarchard, Alpha, ddorwin+watch_chromium.org, Paweł Hajdan Jr., sjl, acolwell, annacc, pam+watch_chromium.org, awong, brettw-cc_chromium.org, scherkus
Visibility:
Public.

Description

Last few NewRunnableMethod scoped_refptr params to fix.

BUG=28083
TEST=builds

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Lint Patch
M chrome/browser/history/history_browsertest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/password_manager/password_store_default_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M media/tools/player_x11/player_x11.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
willchan
I think these are the last 3 finally. I'm going to TBR this so I ...
3 years, 4 months ago #1
Nico
3 years, 4 months ago #2
LG

On Tue, Dec 14, 2010 at 7:30 PM,  <willchan@chromium.org> wrote:
> Reviewers: scherkus, Alpha, Nico,
>
> Message:
> I think these are the last 3 finally.  I'm going to TBR this so I can try to
> land my type trait to turn these bugs into compile errors.
>
> Description:
> Last few NewRunnableMethod scoped_refptr params to fix.
>
> BUG=28083
> TEST=builds
>
> Please review this at http://codereview.chromium.org/5870001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/history/history_browsertest.cc
>  M chrome/browser/password_manager/password_store_default_unittest.cc
>  M media/tools/player_x11/player_x11.cc
>
>
> Index: chrome/browser/history/history_browsertest.cc
> diff --git a/chrome/browser/history/history_browsertest.cc
> b/chrome/browser/history/history_browsertest.cc
> index
>
0d9ac37d7eccf118f8302f84587db0374d60fbe4..7075b163f39f7e49c49eae4892749d63593b083b
> 100644
> --- a/chrome/browser/history/history_browsertest.cc
> +++ b/chrome/browser/history/history_browsertest.cc
> @@ -110,7 +110,7 @@ class HistoryBrowserTest : public InProcessBrowserTest {
>                             FROM_HERE,
>                             NewRunnableMethod(history,
>
> &HistoryService::ScheduleDBTask,
> -                                              task.get(),
> +                                              task,
>                                               &request_consumer));
>     ui_test_utils::RunMessageLoop();
>   }
> Index: chrome/browser/password_manager/password_store_default_unittest.cc
> diff --git
> a/chrome/browser/password_manager/password_store_default_unittest.cc
> b/chrome/browser/password_manager/password_store_default_unittest.cc
> index
>
500a1b4ed03c4929d5fc714c2307644b40a495b5..537b134f760f9cb661f4f96564c6ab3228ab81fa
> 100644
> --- a/chrome/browser/password_manager/password_store_default_unittest.cc
> +++ b/chrome/browser/password_manager/password_store_default_unittest.cc
> @@ -62,7 +62,7 @@ class DBThreadObserverHelper :
>         FROM_HERE,
>         NewRunnableMethod(this,
>                           &DBThreadObserverHelper::AddObserverTask,
> -                          password_store));
> +                          make_scoped_refptr(password_store)));
>     done_event_.Wait();
>   }
>
> Index: media/tools/player_x11/player_x11.cc
> diff --git a/media/tools/player_x11/player_x11.cc
> b/media/tools/player_x11/player_x11.cc
> index
>
ad3bc8d918d72ba0c935f7acbe7091f5a2aa8d88..973e22dec05605ec89713a33e42d82724632c5ae
> 100644
> --- a/media/tools/player_x11/player_x11.cc
> +++ b/media/tools/player_x11/player_x11.cc
> @@ -207,7 +207,7 @@ void PeriodicalUpdate(
>   }
>
>   message_loop->PostDelayedTask(FROM_HERE,
> -      NewRunnableFunction(PeriodicalUpdate, pipeline,
> +      NewRunnableFunction(PeriodicalUpdate, make_scoped_refptr(pipeline),
>                           message_loop, audio_only), 10);
>  }
>
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6