get rid of almost all old fashioned i18nTemplates

chrome/browser/resources/quota_internals/event_handler.js

Index: chrome/browser/resources/quota_internals/event_handler.js
diff --git a/chrome/browser/resources/quota_internals/event_handler.js b/chrome/browser/resources/quota_internals/event_handler.js
index c5ba7a44ffdca9914bb52f8aad9f65a21c18d38d..54f649a217402e1887cdd691bf8389f2566af1c2 100644
--- a/chrome/browser/resources/quota_internals/event_handler.js
+++ b/chrome/browser/resources/quota_internals/event_handler.js
@@ -42,8 +42,8 @@ function copyAttributes_(source, destination) {
  * @private
  */
 function localize_(element) {

[Dan Beam, 2014/09/23 00:13:28]

nit: _ only goes at the end of private members, afaik

[Evan Stade, 2014/09/23 00:54:28]

I don't really want to fix all the cases in this file where that's a problem,
because that would introduce a lot of changes unrelated to this already large
CL. I also don't want to change just one function and leave the rest alone.
Therefore I want to leave them all alone.

-  if (window.i18nTemplate && window.templateData)
-    i18nTemplate.process(element, templateData);
+  if (i18nTemplate && loadTimeData)

[Dan Beam, 2014/09/23 00:13:29]

why did you remove the window.?

[Evan Stade, 2014/09/23 00:54:28]

was it serving a purpose? It's not used before loadTimeData in other webui
files.

[Dan Beam, 2014/09/23 01:03:03]

avoids ReferenceErrors

[Evan Stade, 2014/09/23 01:07:31]

I didn't run into any of those. Are you saying all loadTimeData references
should be prepended by window.? If so, I disagree.

[Evan Stade, 2014/09/23 01:30:00]

Done.

[Dan Beam, 2014/09/23 01:36:29]

just when checking for the existence of a global (like we talked about)

+    i18nTemplate.process(element, loadTimeData);
 };

[Dan Beam, 2014/09/23 00:13:29]

nit: }; -> }

[Evan Stade, 2014/09/23 00:54:28]

Done.

 
 /**
@@ -518,7 +518,6 @@ function dump() {
 
 function onLoad() {
   cr.ui.decorate('tabbox', cr.ui.TabBox);
-  localize_(document);
 
   cr.quota.onAvailableSpaceUpdated.addEventListener('update',
                                                     handleAvailableSpace);