get rid of almost all old fashioned i18nTemplates

chrome/browser/resources/quota_internals/event_handler.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require cr.js
 // require cr/event_target.js
 // require cr/ui.js
 // require cr/ui/tabs.js
 // require cr/ui/tree.js
 // require cr/util.js
@@ skipping 23 matching lines @@
   for (var i in source)
     destination[i] = source[i];
   return destination;
 };
 
 /**
  * Apply localization to |element| with i18n_template.js if available.
  * @param {Element} element Element to be localized.
  * @private
  */
 function localize_(element) {

[Dan Beam, 2014/09/23 00:13:28]

nit: _ only goes at the end of private members, afaik

[Evan Stade, 2014/09/23 00:54:28]

I don't really want to fix all the cases in this file where that's a problem,
because that would introduce a lot of changes unrelated to this already large
CL. I also don't want to change just one function and leave the rest alone.
Therefore I want to leave them all alone.

-  if (window.i18nTemplate && window.templateData)
-    i18nTemplate.process(element, templateData);
+  if (i18nTemplate && loadTimeData)

[Dan Beam, 2014/09/23 00:13:29]

why did you remove the window.?

[Evan Stade, 2014/09/23 00:54:28]

was it serving a purpose? It's not used before loadTimeData in other webui
files.

[Dan Beam, 2014/09/23 01:03:03]

avoids ReferenceErrors

[Evan Stade, 2014/09/23 01:07:31]

I didn't run into any of those. Are you saying all loadTimeData references
should be prepended by window.? If so, I disagree.

[Evan Stade, 2014/09/23 01:30:00]

Done.

[Dan Beam, 2014/09/23 01:36:29]

just when checking for the existence of a global (like we talked about)

+    i18nTemplate.process(element, loadTimeData);
 };

[Dan Beam, 2014/09/23 00:13:29]

nit: }; -> }

[Evan Stade, 2014/09/23 00:54:28]

Done.

 
 /**
  * Returns 'N/A' (Not Available) text if |value| is undefined.
  * @param {Object} value Object to print.
  * @return {string} 'N/A' or ''.
  * @private
  */
 function checkIfAvailable_(value) {
   return value === undefined ? 'N/A' : '';
 }
@@ skipping 453 matching lines @@
       separator +
       JSON.stringify(dumpTreeToObj(), null, 2) + '\n' +
       separator +
       'Misc Statistics\n' +
       separator +
       JSON.stringify(dumpStatisticsToObj(), null, 2);
 }
 
 function onLoad() {
   cr.ui.decorate('tabbox', cr.ui.TabBox);
-  localize_(document);
 
   cr.quota.onAvailableSpaceUpdated.addEventListener('update',
                                                     handleAvailableSpace);
   cr.quota.onGlobalInfoUpdated.addEventListener('update', handleGlobalInfo);
   cr.quota.onPerHostInfoUpdated.addEventListener('update', handlePerHostInfo);
   cr.quota.onPerOriginInfoUpdated.addEventListener('update',
                                                    handlePerOriginInfo);
   cr.quota.onStatisticsUpdated.addEventListener('update', handleStatistics);
   cr.quota.requestInfo();
 
   $('refresh-button').addEventListener('click', cr.quota.requestInfo, false);
   $('dump-button').addEventListener('click', dump, false);
 }
 
 cr.doc.addEventListener('DOMContentLoaded', onLoad, false);
 })();