get rid of almost all old fashioned i18nTemplates

get rid of almost all old fashioned i18nTemplates

BUG=122753
Committed: https://crrev.com/918d530e9f8e1e70d1bca9814d1441b42bf3c60c
Cr-Commit-Position: refs/heads/master@{#296131}

[Evan Stade, 2014-09-20 00:11:22]

estade@chromium.org changed reviewers:
+ dbeam@chromium.org

[Evan Stade, 2014-09-22 21:17:22]

ping

[Dan Beam, 2014-09-23 00:13:29]

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
File chrome/browser/resources/quota_internals/event_handler.js (right):

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:44: function
localize_(element) {
nit: _ only goes at the end of private members, afaik

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:45: if (i18nTemplate
&& loadTimeData)
why did you remove the window.?

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:47: };
nit: }; -> }

[Evan Stade, 2014-09-23 00:54:28]

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
File chrome/browser/resources/quota_internals/event_handler.js (right):

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:44: function
localize_(element) {
On 2014/09/23 00:13:28, Dan Beam wrote:
> nit: _ only goes at the end of private members, afaik

I don't really want to fix all the cases in this file where that's a problem,
because that would introduce a lot of changes unrelated to this already large
CL. I also don't want to change just one function and leave the rest alone.
Therefore I want to leave them all alone.

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:45: if (i18nTemplate
&& loadTimeData)
On 2014/09/23 00:13:29, Dan Beam wrote:
> why did you remove the window.?

was it serving a purpose? It's not used before loadTimeData in other webui
files.

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:47: };
On 2014/09/23 00:13:29, Dan Beam wrote:
> nit: }; -> }

Done.

[Dan Beam, 2014-09-23 01:03:03]

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
File chrome/browser/resources/quota_internals/event_handler.js (right):

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:45: if (i18nTemplate
&& loadTimeData)
On 2014/09/23 00:54:28, Evan Stade wrote:
> On 2014/09/23 00:13:29, Dan Beam wrote:
> > why did you remove the window.?
> 
> was it serving a purpose? It's not used before loadTimeData in other webui
> files.

avoids ReferenceErrors

[Evan Stade, 2014-09-23 01:07:32]

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
File chrome/browser/resources/quota_internals/event_handler.js (right):

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:45: if (i18nTemplate
&& loadTimeData)
On 2014/09/23 01:03:03, Dan Beam wrote:
> On 2014/09/23 00:54:28, Evan Stade wrote:
> > On 2014/09/23 00:13:29, Dan Beam wrote:
> > > why did you remove the window.?
> > 
> > was it serving a purpose? It's not used before loadTimeData in other webui
> > files.
> 
> avoids ReferenceErrors

I didn't run into any of those. Are you saying all loadTimeData references
should be prepended by window.? If so, I disagree.

[Evan Stade, 2014-09-23 01:30:00]

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
File chrome/browser/resources/quota_internals/event_handler.js (right):

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:45: if (i18nTemplate
&& loadTimeData)
On 2014/09/23 01:07:31, Evan Stade wrote:
> On 2014/09/23 01:03:03, Dan Beam wrote:
> > On 2014/09/23 00:54:28, Evan Stade wrote:
> > > On 2014/09/23 00:13:29, Dan Beam wrote:
> > > > why did you remove the window.?
> > > 
> > > was it serving a purpose? It's not used before loadTimeData in other webui
> > > files.
> > 
> > avoids ReferenceErrors
> 
> I didn't run into any of those. Are you saying all loadTimeData references
> should be prepended by window.? If so, I disagree.

Done.

[Dan Beam, 2014-09-23 01:36:30]

lgtm

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
File chrome/browser/resources/quota_internals/event_handler.js (right):

https://codereview.chromium.org/586953002/diff/1/chrome/browser/resources/quo...
chrome/browser/resources/quota_internals/event_handler.js:45: if (i18nTemplate
&& loadTimeData)
On 2014/09/23 01:07:31, Evan Stade wrote:
> On 2014/09/23 01:03:03, Dan Beam wrote:
> > On 2014/09/23 00:54:28, Evan Stade wrote:
> > > On 2014/09/23 00:13:29, Dan Beam wrote:
> > > > why did you remove the window.?
> > > 
> > > was it serving a purpose? It's not used before loadTimeData in other webui
> > > files.
> > 
> > avoids ReferenceErrors
> 
> I didn't run into any of those. Are you saying all loadTimeData references
> should be prepended by window.? If so, I disagree.

just when checking for the existence of a global (like we talked about)

[Evan Stade, 2014-09-23 01:39:38]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-23 01:40:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/586953002/40001

[commit-bot: I haz the power, 2014-09-23 02:37:38]

Committed patchset #3 (id:40001) as 07e92abc8205a45f7adeab1e6606b44549cee7df

[commit-bot: I haz the power, 2014-09-23 02:38:05]

Patchset 3 (id:??) landed as
https://crrev.com/918d530e9f8e1e70d1bca9814d1441b42bf3c60c
Cr-Commit-Position: refs/heads/master@{#296131}